Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI + Testing + Bugfixes for path + misc. fixes + linting #81

Merged
merged 35 commits into from
Oct 20, 2023

Conversation

nandantumu
Copy link
Member

This is an initial implementation of CI pipelines. In order to separate failures, test failures and linting failures are implemented as their own pipelines. Tests were ported to the tests directory. Much of these tests are still not really functional. Regression testing must be a contribution priority moving forward.

@nandantumu nandantumu changed the base branch from main to v1.0.0 July 8, 2023 01:11
Added Linting Badge
Added failure mode to badge
@nandantumu
Copy link
Member Author

All of the tests fail, but this is on purpose.

@luigiberducci
Copy link
Collaborator

@nandantumu
The utility functions in the test of collision models are duplicated (I have missed that in dev_refactoring).
Please delete them and keep them in collision_models.py in the next commit

@nandantumu nandantumu marked this pull request as ready for review August 22, 2023 23:07
@nandantumu
Copy link
Member Author

The build fails, this is expected. Bugfixes are required.

@nandantumu nandantumu marked this pull request as draft August 23, 2023 15:16
@luigiberducci
Copy link
Collaborator

@nandantumu test_scan_sim.py uses matplotlib to visualize the scans in polar coordinates.
What about removing that code?

@nandantumu nandantumu marked this pull request as ready for review September 28, 2023 21:38
@nandantumu
Copy link
Member Author

Fixed the issues with the map download on windows, and the path issues in the tests.

@nandantumu
Copy link
Member Author

This is now good to merge, imo. All linting errors have been cleared, the only test that fails is the ST dynamics, which only fail by a small amount. I believe this is linked to #53

@nandantumu nandantumu changed the title Dev ci testing CI + Testing + Bugfixes for path + misc. fixes + linting Oct 5, 2023
Copy link
Collaborator

@luigiberducci luigiberducci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored tests that contain utility functions (shadowing the actual utilities to test).

Apart from the dynamics test, which should probably be addressed separately, looks good to me.

gym/f110_gym/envs/cubic_spline.py Outdated Show resolved Hide resolved
gym/f110_gym/envs/f110_env.py Show resolved Hide resolved
gym/f110_gym/envs/observation.py Show resolved Hide resolved
- Removing Spielberg
- Removing __del__ from f110_env
@nandantumu nandantumu merged commit 15d8f03 into v1.0.0 Oct 20, 2023
2 of 8 checks passed
@luigiberducci luigiberducci deleted the dev_ci_testing branch February 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants