Add reasonable defaults for primitive preferences. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
f2prateek
force-pushed
the
null-safe-defaults
branch
from
07ec02a
to
a73c2ed
Compare
| @CheckResult @NonNull | ||
| public Preference<Integer> getInteger(@NonNull String key) { | ||
| return getInteger(key, null); | ||
| //noinspection UnnecessaryBoxing | ||
| return getInteger(key, Integer.valueOf(0)); |
There was a problem hiding this comment.
Why the inconsistent use of constants to cache these instances?
There was a problem hiding this comment.
Yup, should use Boolean.valueOf above. But probably want to cache Float ourselves, since it always returns a new instance.
There was a problem hiding this comment.
I would probably cache them all in DEFAULT_<foo> static fields in this class to be explicit. Relying on the caching/interning of instance of Java seems a bit too implicit.
This commit adds reasonable defaults (`false` for booleans and `0` for numbers) to the factory methods for primitve preference types. Using `null` as the default for primitive preference types will trip people if they try to automatically unwrap `null` values when a preference doesn't exist.
f2prateek
force-pushed
the
null-safe-defaults
branch
from
a73c2ed
to
5c13632
Compare
f2prateek
added a commit
that referenced
this pull request
Oct 4, 2015
Add reasonable defaults for primitive preferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds reasonable defaults (
falsefor booleans and0fornumbers) to the factory methods for primitve preference types.
Using
nullas the default for primitive preference types will trippeople if they try to automatically unwrap those values when a
preference doesn't exist.