-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools and benchmark datasets to read compressed json #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for adding the support for the JSON format. But I'd like to keep the option to generate and read metrics/logs/traces data in a binary format. The main reason is that I have a bunch of data already used in various benchmarks and I need to keep them in order to reproduce them.
The JSON+ZSTD should be integrated as an additional supported format and not as a replacement for the binary format.
@moh-osman3 there is an issue in the build process preventing us to merge this PR. Could you fix it and I will merge this PR. Thanks. |
Head branch was pushed to by a user without write access
@lquerel Ahh forgot to update one of the test files with the updated function signature. I think it should be fixed now. Thank you! |
@moh-osman3 thanks for this PR. |
What does this PR do?
This PR