Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify OTel Arrow decoding #175

Merged

Conversation

lquerel
Copy link
Contributor

@lquerel lquerel commented Jun 8, 2023

Validation test improvements:

  • This PR introduces a layer between encoding and decoding layers to mess up with OTel Arrow records. The goal is to make the decoding layer more robust to invalid streams even if individually each Arrow record is technically well-formed.
  • The decoding layer should not panic even if the incoming data are invalid (purposely or not). In such situation, the decoding layer should return an error that the collector need to handle.

Bugs fixed:

  • Logs with an empty body are now correctly handled.

@lquerel lquerel linked an issue Jun 8, 2023 that may be closed by this pull request
@lquerel lquerel marked this pull request as ready for review June 10, 2023 00:15
@lquerel lquerel requested a review from jmacd June 10, 2023 00:15
@lquerel lquerel self-assigned this Jun 10, 2023
@lquerel lquerel added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jun 10, 2023
@lquerel lquerel added this to the V1 milestone Jun 10, 2023
@lquerel lquerel merged commit 534d56b into main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Create invalid OTel Arrow streams and see what happens
2 participants