Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fileexporter component with updated functionality #185

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

moh-osman3
Copy link
Contributor

@moh-osman3 moh-osman3 commented Jun 22, 2023

What does this PR do?

This PR adds the fileexporter component directly rather than using the component currently in opentelemetry-collector-contrib package.

Adding the component directly allows us to use the functionality from this PR open in the contrib repository. This contrib PR is taking a while to get approved so in the meantime it might be better to add these changes to start using these components to record data in production.

Example config

exporters:
  file:
    path: ../../gen/receiver/filereceiver/testdata/metrics.pb
    compression: zstd
    format: proto

Testing

Ran the cmd/otelarrowcol with the fileexporter component and successfully wrote to file in the desired format/compression

(cc: @jmacd)

@moh-osman3 moh-osman3 force-pushed the mohosman/fileexporter-component branch from d54f398 to 56312cb Compare June 22, 2023 09:07
@moh-osman3 moh-osman3 marked this pull request as ready for review June 22, 2023 17:34
Copy link
Collaborator

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to be short-lived, as we wait for the contrib repo to accept & review this functionality. Until then, it will be nice to be able to run telemetry-generator from in-repo components. Thanks @moh-osman3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants