Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less logging in two places #189

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Less logging in two places #189

merged 2 commits into from
Jun 26, 2023

Conversation

jmacd
Copy link
Collaborator

@jmacd jmacd commented Jun 26, 2023

This avoids two logger.Error statements, downgrades them to info statements. This produces a lot less logging volume for us because it does not log stacktraces for non-error events.

@jmacd jmacd requested a review from lquerel June 26, 2023 15:49
Copy link
Contributor

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lquerel lquerel enabled auto-merge (squash) June 26, 2023 15:50
@lquerel lquerel merged commit 5441766 into f5:main Jun 26, 2023
@jmacd jmacd deleted the jmacd/less_logging branch June 26, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants