Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use critical struct for freeaim and jump #1088

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

SoDOOManiac
Copy link
Collaborator

@SoDOOManiac SoDOOManiac commented Aug 23, 2023

While cleaning up my amateur mistakes to prepare the new release of So Doom I noticed that Crispy code looks to contain flaws that may be seldom triggered.
The physical gameplay tweaks that affect demo sync and netplay should be set up as crispy->criticalfield in 4 files only:
compatibility.c, d_main.c, m_crispy.c and m_menu.c.
In all other files the critical structure pointer should be used instead of crispy, critical points to crispy_s struct in singleplayer (non-demo, non-netgame) and to the all-zeros-initialized critical_s otherwise.

I cleaned out what looks to me like the wrong use of crispy-> instead of critical->.

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@fabiangreffrath fabiangreffrath merged commit eb16c63 into master Aug 24, 2023
6 checks passed
@fabiangreffrath fabiangreffrath deleted the critical-struct branch August 24, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants