Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke ST_doPaletteStuff every game tic, not every frame #1122

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

JNechaevsky
Copy link
Collaborator

Same as described and done in fabiangreffrath/woof#1316. Few remarks:

  • Heretic have void SB_PaletteFlash(void) in p_local.h. Kept it there for smaller diff, so no static declaration.
  • Hexen handles F11 just a very little bit different, so call for SB_PaletteFlash(true) is still needed in mn_menu.c
  • Maybe add some comments?

Copy link
Owner

@fabiangreffrath fabiangreffrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@JNechaevsky
Copy link
Collaborator Author

Thanks! I was worried about Hexen calls with condition of consoleplayer like this one, but it's seems to be okay since SB_PaletteFlash itself is always referring to consoleplayer. But this PR does not improves multiplayer spy mode, as it was done for Doom already.

@JNechaevsky JNechaevsky merged commit c225273 into master Dec 14, 2023
6 checks passed
@JNechaevsky JNechaevsky deleted the st_ticker branch December 14, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants