Doom: fix blinking of drawing Tower of Babel on intermission screen #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiangreffrath
approved these changes
Apr 19, 2024
|
Thanks for accepting! Should it be fixed in Woof as well? The case and fix is 100% identical there. |
|
Sure, why not. Would you file a PR? |
|
Of course, gladly, will do soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very, very minor thing, but once you'll notice, it can't be unseen. Fortunately, the fix is very easy - we have to initialize animation variables (
a->ctr = -1;) just once, when we are entering tally screen, and don't touch them when switching to "Entering" screen.However! This fixes not only Tower of Babel itself, but whole animations on all three episodes. But such breaks in all other animations will be hard to notice since they are small. Probably red sky in E3 background is more or less noticeable.
Easiest way to see tower's blinking is an exit from E2M7, as in this state tower is almost built and it's sprite is tall enough.
Initial suggestion and video example: in JNechaevsky/international-doom#122