hexen: Fix wrong save being deleted #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a save occurs on pages 1, 2 or 3, it has the potential to delete the save in the corresponding slot on pages 2, 4 or 6.
|
I was not involved in this code and while it looks fine to me, I still struggle to understand it entirely. Could you please elaborate a bit about the differences between the two functions and when the one is used and when the other? Thank you! |
|
I agree that it's a little confusing. I took the opportunity to refactor and I think the intent of the code is clearer now. |
fabiangreffrath
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was prompted to look into this code again after I saw this post on DW. I found an issue where saving a savefile on pages 1, 2 or 3 can potentially delete the save in the corresponding slot on page 2, 4 or 6 respectively. Not sure if this has any relation to the issue reported by the user on DW, but this bug should certainly be fixed regardless.