Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with webpack #263

Open
wants to merge 1 commit into
base: 0.3
Choose a base branch
from
Open

Working with webpack #263

wants to merge 1 commit into from

Conversation

laterbreh
Copy link

Hi, I have been using Alertify with Webpack for a while, and I always had changed:
Line 626 from:

(this));

To:

(window));

Works normally with this change even when not using webpack (Though I have not extensively used it outside of Webpack, but it seems to work perfectly).

Just thought I'd drop the pull request so this line does not have to be changed every time it's installed via NPM for Webpack users.

If you don't want this, its OK, just thought I'd make a suggestion.

Thanks!

@laterbreh
Copy link
Author

I also noticed in the issues #248 mentioned this.

@micahalcorn
Copy link

micahalcorn commented Feb 20, 2018

@laterbreh do you happen to have your fork on NPM? Or do you know of a way to configure webpack to play nice with this old version Alertify? 🙏

@laterbreh
Copy link
Author

@micahalcorn

Check the files changed tab on this pull, just swap this to window as demonstrated in the pull request.

Hopefully that helps!

@micahalcorn
Copy link

micahalcorn commented Feb 20, 2018

@laterbreh thanks, I had confirmed that it worked, but I need a reliable way to include it in an open-source project so that everyone doesn't have to tweak their node installation. I don't have any webpack experience, but I was hoping that there was a way to get it working as an AMD module. 😕

Although it actually seems to be using the AMD factory even though define is undefined in my experience. I'm not sure how that's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants