Now setting the X-Forwarded-Host header if not present. Add matching … #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey can we have a feedback on this one? Thanks! |
|
Hi @LeReverandNox and @commarla, thanks for both the PR and the nudge. The last couple of weeks were a bit more stressful than expected. I've merged the PR and added some subsequent commits to clean it up (integration test, ordering, simplifying). Nothing major. Thanks again! Frank |
magiconair
added a commit
that referenced
this pull request
Nov 30, 2017
magiconair
added a commit
that referenced
this pull request
Nov 30, 2017
magiconair
added a commit
that referenced
this pull request
Nov 30, 2017
|
Thanks to you @magiconair |
|
Thanks a lot @magiconair ! We owe you one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…unit tests.
Hi @magiconair,
I needed to have the X-Forwarded-Host header for many of my services, so here it is :)
Let me know if there's wrong with it.
Thanks !
LeReverandNox