Mark warning messages as important. Fixes microsoft#170

fabioz · Jan 20, 2022 · f3c631c · f3c631c
1 parent 5adc45e
commit f3c631c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_net_command_factory_json.py b/src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_net_command_factory_json.py
@@ -294,7 +294,7 @@ def make_get_thread_stack_message(self, py_db, seq, thread_id, topmost_frame, fm
 
     @overrides(NetCommandFactory.make_warning_message)
     def make_warning_message(self, msg):
-        category = 'console'
+        category = 'important'
         body = OutputEventBody(msg, category)
         event = OutputEvent(body)
         return NetCommand(CMD_WRITE_TO_CONSOLE, 0, event, is_json=True)

diff --git a/src/debugpy/_vendored/pydevd/tests_python/test_debugger_json.py b/src/debugpy/_vendored/pydevd/tests_python/test_debugger_json.py
@@ -1458,9 +1458,11 @@ def test_case_skipping_filters(case_setup, custom_setup):
         messages = json_facade.mark_messages(
             OutputEvent, lambda output_event: 'Frame skipped from debugging during step-in.' in output_event.body.output)
         assert len(messages) == 1
-        found_just_my_code = 'Note: may have been skipped because of \"justMyCode\" option (default == true)' in next(iter(messages)).body.output
+        body = next(iter(messages)).body
+        found_just_my_code = 'Note: may have been skipped because of \"justMyCode\" option (default == true)' in body.output
 
         assert found_just_my_code == expect_just_my_code
+        assert body.category == 'important'
 
         json_facade.write_step_in(json_hit.thread_id)
         json_hit = json_facade.wait_for_thread_stopped('step', name='callback2')

diff --git a/tests/debug/session.py b/tests/debug/session.py
@@ -179,6 +179,7 @@ def __init__(self, debug_config=None):
                 timeline.Event("output", some.dict.containing({"category": "stdout"})),
                 timeline.Event("output", some.dict.containing({"category": "stderr"})),
                 timeline.Event("output", some.dict.containing({"category": "console"})),
+                timeline.Event("output", some.dict.containing({"category": "important"})),
             ]
         )