Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Devices #148

Merged
merged 15 commits into from
Sep 3, 2019
Merged

Private Devices #148

merged 15 commits into from
Sep 3, 2019

Conversation

viktorsmari
Copy link
Collaborator

@viktorsmari viktorsmari commented Aug 17, 2019

  • Add is_private (boolean) to Devices with default:false
  • Add a researcher role (with a role_mask = 3)
  • Admins can see all devices, even if they are private.
  • Logged in users can see public + all their own devices
  • Not logged in users only see public devices.
  • Only superusers or admins (not normal users) can change their devices is_private attribute

See #147 for details

@viktorsmari viktorsmari changed the title WIP: role_mask 3 is now a 'superuser' WIP: Private Devices Aug 17, 2019
@viktorsmari viktorsmari marked this pull request as ready for review September 2, 2019 12:15
@viktorsmari viktorsmari changed the title WIP: Private Devices Private Devices Sep 3, 2019
Copy link

@tuengominh tuengominh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-noted Viktor!

@viktorsmari viktorsmari merged commit 34e442d into master Sep 3, 2019
@viktorsmari viktorsmari deleted the private-devices branch November 12, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants