New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle device not found #150

Merged

viktorsmari merged 2 commits into master from handle-device-not-found

Nov 7, 2019

Collaborator

viktorsmari commented Oct 23, 2019 •

edited

Loading

TODO:

Add test for when a device is not found
What to do if it is not found? Simply do nothing?
Refactor: create a method to reuse the device = Device.find_by(device_token: self.device_token(topic)) in more places?

Sentry error screenshot:

viktorsmari added 2 commits

October 23, 2019 11:49


          Handle device not found

7c79620


          MQTT: handle more devices not found

f308d33

viktorsmari merged commit 64fe335 into master

viktorsmari deleted the handle-device-not-found branch

November 7, 2019 11:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet