Refactor mqtt handler #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
viktorsmari
commented
Apr 9, 2020
•
viktorsmari
commented
- Return early if topic is nil
- Return early if device is nil
- Remove Raven capture if device was nil - was flooding our Sentry
- Add test for empty inventory topic
Return early if topic is nil Return early if device is nil Add test for empty inventory topic
viktorsmari
commented
Apr 9, 2020
app/lib/mqtt_messages_handler.rb
Outdated
| payload[:device_id] = device.id | ||
| end | ||
| payload[:device_id] = device.id | ||
| payload[:device_token] = device.device_token # TODO: remove after migration |
There was a problem hiding this comment.
@pral2a do you remember if we should remove this line now?
There was a problem hiding this comment.
Yes, we can remove it, finally! That is an important decision as it fixes a critical vulnerability
pral2a
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.