New Raw MQTT Message parser #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to staging, on branch |
|
TODO: ensure that no parser errors are "swallowed" - errors should be reported (but also see #288 - it maybe makes sense to just do this directly) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #326 and errors in sentry arising from weird unicode characters in messages, also quite a nice refactoring, i think,
Uses a treetop parsing expression grammar for our "pseudojson" format, and use it to convert directly to the "non raw" extended json. Have also tidied up the message handler a little bit in general to help with readability, and added more comprehensive tests for raw message parsing.