Updates /register and /report API return status codes description #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patchset updates /register and /report APIs return status code descriptions.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
navidshaikh
commented
Aug 14, 2018
There was a problem hiding this comment.
@abs51295 @samuzzal-choudhury : I have asked few queries, at places where I need to add changes.
| @@ -47,15 +47,15 @@ paths: | |||
| '200': | |||
| schema: | |||
| $ref: "#/definitions/RegisterResponse" | |||
| description: Repository registered | |||
| description: Git repository is registered for scan at Gemini API server. | |||
| '400': | |||
| description: Bad request from the client | |||
There was a problem hiding this comment.
@abs51295 @samuzzal-choudhury : Why do we have 400 for /register API call?
| '400': | ||
| description: Bad request from the client | ||
| '401': | ||
| description: Request unauthorized | ||
| description: Unauthorized request from the client. Kindly if check access token is valid or expired. | ||
| '404': |
There was a problem hiding this comment.
What does 404 mean for /register API call ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset updates /register and /report APIs return status code
descriptions.