Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

fix: reset result when either 404 or 409 is ignored #738

Conversation

MatousJobanek
Copy link
Contributor

@MatousJobanek MatousJobanek commented Jan 23, 2019

reset result when either 404 or 409 is ignored to not be checked in followings callbacks
make printing of the warnings shorter

@MatousJobanek MatousJobanek changed the title fix: reset result when conflict is ignored fix: reset result when either 404 or 409 is ignored Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #738 into develop will increase coverage by 0.17%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #738      +/-   ##
===========================================
+ Coverage     74.6%   74.77%   +0.17%     
===========================================
  Files           37       37              
  Lines         2934     2938       +4     
===========================================
+ Hits          2189     2197       +8     
+ Misses         561      557       -4     
  Partials       184      184
Impacted Files Coverage Δ
openshift/callback.go 77.5% <80%> (+0.57%) ⬆️
update/update.go 82.24% <0%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f6c55...9baf24e. Read the comment docs.

@MatousJobanek MatousJobanek merged commit 8e221ab into fabric8-services:develop Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant