This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Search by label name #2277
Merged
Search by label name #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
Codecov Report
@@ Coverage Diff @@
## master #2277 +/- ##
==========================================
+ Coverage 69.47% 69.47% +<.01%
==========================================
Files 175 175
Lines 16466 16477 +11
==========================================
+ Hits 11439 11448 +9
- Misses 3927 3928 +1
- Partials 1100 1101 +1
Continue to review full report at Codecov.
|
|
[test] |
Fixes work item no. 483
|
[test] |
2 similar comments
|
[test] |
|
[test] |
jarifibrahim
approved these changes
Sep 10, 2018
baijum
added a commit
to baijum/saas-openshiftio
that referenced
this pull request
Sep 10, 2018
# About
This description was generated using this script:
```sh
#!/bin/bash
set -e
GHORG=${GHORG:-fabric8-services}
GHREPO=${GHREPO:-fabric8-wit}
cat <<EOF
# About
This description was generated using this script:
\`\`\`sh
`cat $0`
\`\`\`
Invoked as:
`echo GHORG=${GHORG} GHREPO=${GHREPO} $(basename $0) ${@:1}`
# Changes
EOF
git log \
--pretty="%n**Commit:** https://github.com/${GHORG}/${GHREPO}/commit/%H%n**Author:** %an (%ae)%n**Date:** %aI%n%n%s%n%n%b%n%n----%n" \
--reverse ${@:1} \
| sed -E "s/([\s|\(| ])#([0-9]+)/\1${GHORG}\/${GHREPO}#\2/g"
```
Invoked as:
GHORG=fabric8-services GHREPO=fabric8-wit osio-pull.sh 4909a90aef93ad7efc600faa43e7f0037a04de54..upstream/master
# Changes
**Commit:** fabric8-services/fabric8-wit@1f5acd8
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-09-07T18:09:54+02:00
Make the board column tests cleanup after themselves (fabric8-services/fabric8-wit#2278)
Possibly related to openshiftio/openshift.io#4299
----
**Commit:** fabric8-services/fabric8-wit@5f057eb
**Author:** Xavier Coulon (xcoulon@redhat.com)
**Date:** 2018-09-10T07:14:15+02:00
Provide endpoint to list spaces in which a user has a role (fabric8-services/fabric8-wit#2260)
* Provide endpoint to list spaces in which a user has a role
Added endpoint in `UserController`
Added tests in `user_blackbox_test.go` using go-vcr
to handle requests/responses with remote auth service.
fixes fabric8-services/fabric8-wit#2241
fixes fabric8-services/fabric8-auth#617
fixes openshiftio/openshift.io#3760
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
----
**Commit:** fabric8-services/fabric8-wit@162bc65
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-09-10T13:15:37+05:30
Use %q instead of "%s" (fabric8-services/fabric8-wit#2279)
This commit replaces all occurrences of \"%s\" with %q.
From the documentation of https://golang.org/pkg/fmt/
`%q a double-quoted string safely escaped with Go syntax`
----
**Commit:** fabric8-services/fabric8-wit@164762f
**Author:** Baiju Muthukadan (baiju.m.mail@gmail.com)
**Date:** 2018-09-10T13:52:35+05:30
Search by label name (fabric8-services/fabric8-wit#2277)
Fixes work item no. 483
Syntax: `{"label.name":"somelabel"}`
----
kwk
reviewed
Sep 10, 2018
| AND lbl.id::text IN ( | ||
| SELECT | ||
| jsonb_array_elements_text(` + Column(WorkItemStorage{}.TableName(), "fields") + `->'system.labels') | ||
| FROM labels)`, |
There was a problem hiding this comment.
@baijum I think we should limit this by the space ID as well; otherwise we'll be searching many labels.
kwk
pushed a commit
to openshiftio/saas-openshiftio
that referenced
this pull request
Sep 10, 2018
# Changes **Commit:** fabric8-services/fabric8-wit@1f5acd8 **Author:** Konrad Kleine (193408+kwk@users.noreply.github.com) **Date:** 2018-09-07T18:09:54+02:00 Make the board column tests cleanup after themselves (fabric8-services/fabric8-wit#2278) Possibly related to openshiftio/openshift.io#4299 ---- **Commit:** fabric8-services/fabric8-wit@5f057eb **Author:** Xavier Coulon (xcoulon@redhat.com) **Date:** 2018-09-10T07:14:15+02:00 Provide endpoint to list spaces in which a user has a role (fabric8-services/fabric8-wit#2260) * Provide endpoint to list spaces in which a user has a role Added endpoint in `UserController` Added tests in `user_blackbox_test.go` using go-vcr to handle requests/responses with remote auth service. fixes fabric8-services/fabric8-wit#2241 fixes fabric8-services/fabric8-auth#617 fixes openshiftio/openshift.io#3760 Signed-off-by: Xavier Coulon <xcoulon@redhat.com> ---- **Commit:** fabric8-services/fabric8-wit@162bc65 **Author:** Ibrahim Jarif (jarifibrahim@gmail.com) **Date:** 2018-09-10T13:15:37+05:30 Use %q instead of "%s" (fabric8-services/fabric8-wit#2279) This commit replaces all occurrences of \"%s\" with %q. From the documentation of https://golang.org/pkg/fmt/ `%q a double-quoted string safely escaped with Go syntax` ---- **Commit:** fabric8-services/fabric8-wit@164762f **Author:** Baiju Muthukadan (baiju.m.mail@gmail.com) **Date:** 2018-09-10T13:52:35+05:30 Search by label name (fabric8-services/fabric8-wit#2277) Fixes work item no. 483 Syntax: `{"label.name":"somelabel"}` ----
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://openshift.io/openshiftio/Openshift_io/plan/detail/483