Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Remove redundant code and fix typo #2329

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

jarifibrahim
Copy link
Member

This PR fixes minor typo and removes redundant code.

@jarifibrahim jarifibrahim self-assigned this Oct 24, 2018
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #2329 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2329      +/-   ##
==========================================
- Coverage   70.16%   70.15%   -0.01%     
==========================================
  Files         171      171              
  Lines       16629    16625       -4     
==========================================
- Hits        11668    11664       -4     
  Misses       3830     3830              
  Partials     1131     1131
Impacted Files Coverage Δ
controller/workitem.go 81.18% <ø> (+0.22%) ⬆️
workitem/workitem_repository.go 67.79% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9879836...a33ad0e. Read the comment docs.

Copy link
Contributor

@DhritiShikhar DhritiShikhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarifibrahim jarifibrahim merged commit 44739f8 into fabric8-services:master Oct 25, 2018
@jarifibrahim jarifibrahim deleted the fix-typo branch October 25, 2018 05:27
kwk pushed a commit to openshiftio/saas-openshiftio that referenced this pull request Oct 30, 2018
# Changes

**Commit:** fabric8-services/fabric8-wit@11904c7
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T13:49:39+02:00

Assign number to new areas/iterations and allow searching by it (fabric8-services/fabric8-wit#2311)

----

**Commit:** fabric8-services/fabric8-wit@8674b7b
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-10T16:58:17+02:00

update number for existing iterations (fabric8-services/fabric8-wit#2314)

----

**Commit:** fabric8-services/fabric8-wit@e67b5e2
**Author:** nurali-techie (nurali.techie@gmail.com)
**Date:** 2018-10-15T14:00:33+05:30

stop calling analytics api for cve scan reg/de-reg (fabric8-services/fabric8-wit#2316)

----

**Commit:** fabric8-services/fabric8-wit@37a913a
**Author:** Baiju Muthukadan (baiju.m.mail@gmail.com)
**Date:** 2018-10-15T17:07:20+05:30

Include fabric8-common as a dependency (fabric8-services/fabric8-wit#2318)

----

**Commit:** fabric8-services/fabric8-wit@e09b805
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-15T14:44:35+02:00

Use Postgres CTE to update iteration numbers (fabric8-services/fabric8-wit#2319)

----

**Commit:** fabric8-services/fabric8-wit@1724c15
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T10:12:56+05:30

Rearrage search repository blackbox tests (fabric8-services/fabric8-wit#2322)

----

**Commit:** fabric8-services/fabric8-wit@7fda6af
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T13:49:11+05:30

Make agile default template for space creation (fabric8-services/fabric8-wit#2323)

----

**Commit:** fabric8-services/fabric8-wit@7b78cf6
**Author:** Konrad Kleine (193408+kwk@users.noreply.github.com)
**Date:** 2018-10-23T11:54:01+02:00

Postpone iteration number update (fabric8-services/fabric8-wit#2325)

----

**Commit:** fabric8-services/fabric8-wit@22e3d5d
**Author:** Dhriti Shikhar (dhriti.shikhar.rokz@gmail.com)
**Date:** 2018-10-23T16:06:35+05:30

Enable the delete workitem endpoint (fabric8-services/fabric8-wit#2305)

----

**Commit:** fabric8-services/fabric8-wit@3d163c7
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-23T17:45:11+05:30

Increase deployment timeout to 2X (fabric8-services/fabric8-wit#2327)

----

**Commit:** fabric8-services/fabric8-wit@9879836
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-24T11:30:20+05:30

Do not throw 500 on invalid value type in search API (fabric8-services/fabric8-wit#2321)

----

**Commit:** fabric8-services/fabric8-wit@44739f8
**Author:** Ibrahim Jarif (jarifibrahim@gmail.com)
**Date:** 2018-10-25T10:57:03+05:30

Remove redundant code and fix typo (fabric8-services/fabric8-wit#2329)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants