Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing events from relist #3318

Closed
shawkins opened this issue Jul 14, 2021 · 0 comments · Fixed by #3319
Closed

Missing events from relist #3318

shawkins opened this issue Jul 14, 2021 · 0 comments · Fixed by #3319
Assignees
@shawkins

Comments

@shawkins
Copy link
Contributor

Something that was in the original implementation was treating relist add/updates as synchronization:

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/cache/DeltaFIFO.java

Line 167 in c112f2d

this.queueActionLocked(DeltaType.SYNCHRONIZATION, obj);

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/informers/impl/DefaultSharedIndexInformer.java

Line 191 in e9ea28e

this.processor.distribute(new ProcessorListener.AddNotification(delta.getValue()), isSync);

This was carried into the refactoring, but that does need changed. It should only be a sync event if it's an update where the resourceVersion is unchanged.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 14, 2021
@shawkins
fix fabric8io#3318: add and actual updates on relist should not be sy…
4333cb1 
…nc events
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 14, 2021
@shawkins
fix fabric8io#3318: add and actual updates on relist should not be sy…
1d05672 
…nc events
@shawkins shawkins linked a pull request Jul 14, 2021 that will close this issue
fix #3318: add and actual updates on relist should not be sync events #3319
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 14, 2021
@shawkins
fix fabric8io#3318: add and actual updates on relist should not be sy…
6b0376f 
…nc events
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jul 14, 2021
@shawkins
fix fabric8io#3318: add and actual updates on relist should not be sy…
49a1074 
…nc events
@rohanKanojia rohanKanojia mentioned this issue Jul 14, 2021
Merged
11 tasks
manusa pushed a commit that referenced this issue Jul 15, 2021
@shawkins @manusa
fix #3318: add and actual updates on relist should not be sync events
8fe5c8c
@shawkins shawkins mentioned this issue Jul 21, 2021
Merged
8 tasks
@shawkins shawkins mentioned this issue Sep 2, 2021
Closed
@shawkins shawkins mentioned this issue Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #3318: add and actual updates on relist should not be sync events shawkins/kubernetes-client
1 participant
@shawkins