Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HasMetadata.getFullResourceName is incorrect when group is empty (which happens for "historic" resources such as Pod) #3712

Closed
metacosm opened this issue Jan 4, 2022 · 0 comments · Fixed by #3713
Closed

HasMetadata.getFullResourceName is incorrect when group is empty (which happens for "historic" resources such as Pod) #3712

metacosm opened this issue Jan 4, 2022 · 0 comments · Fixed by #3713
Assignees
@metacosm
Milestone
5.12.0

Comments

@metacosm
Copy link
Collaborator

metacosm commented Jan 4, 2022

Describe the bug

getFullResourceName returns pods. instead of pods for example.

Fabric8 Kubernetes Client version

5.10.1@latest

Steps to reproduce

Call getFullResourceName on a resource with an empty group.

Expected behavior

Proper full resource name.

Runtime

Kubernetes (vanilla)

Kubernetes API Server version

1.22.3@latest

Environment

macOS

Fabric8 Kubernetes Client Logs

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
5.12.0
Development

Successfully merging a pull request may close this issue.

fix: properly return full resource name for resources with empty group fabric8io/kubernetes-client
2 participants
@metacosm @manusa