Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLUtils.isHttpsAvailable should use an HttpURLConnection instead of an HttpClient #3832

Closed
shawkins opened this issue Feb 10, 2022 · 0 comments · Fixed by #3836
Closed

SSLUtils.isHttpsAvailable should use an HttpURLConnection instead of an HttpClient #3832

shawkins opened this issue Feb 10, 2022 · 0 comments · Fixed by #3836
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

Is your task related to a problem? Please describe

isHttpsAvailable bypasses any HttpClient.Factory associated with a higher level construct such as builder for creating the clients.

Describe the solution you'd like

Directly use HttpURLConnection, rather than constructing and immediately destroying a client.

Describe alternatives you've considered

No response

Additional context

See #1883
@shawkins shawkins added this to the 6.0.0 milestone Feb 10, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 10, 2022
@shawkins
fix fabric8io#3832 fabric8io#1883 simplifying the isHttpsAvailable check
fe16a36
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Feb 10, 2022
@shawkins
fix fabric8io#3832 fabric8io#1883 simplifying the isHttpsAvailable check
437c6f5
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Feb 16, 2022
@shawkins @manusa
fix fabric8io#3832 fabric8io#1883 simplifying the isHttpsAvailable check
478a7aa
@manusa manusa mentioned this issue Feb 16, 2022
Merged
11 tasks
manusa pushed a commit that referenced this issue Feb 16, 2022
@shawkins @manusa
fix #3832 #1883 simplifying the isHttpsAvailable check
45e4975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

fix #3832 #1883 simplifying the isHttpsAvailable check shawkins/kubernetes-client
1 participant
@shawkins