Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

informOnCondition should not test initial add events #4082

Closed
shawkins opened this issue Apr 21, 2022 · 1 comment · Fixed by #4083
Closed

informOnCondition should not test initial add events #4082

shawkins opened this issue Apr 21, 2022 · 1 comment · Fixed by #4083
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

Is your enhancement related to a problem? Please describe

If you are using informOnCondition to check for non-existence the initial add events will provide a partial list and therefore potentially a misleading state.

Describe the solution you'd like

Test the state initially based upon the full list.

Describe alternatives you've considered

No response

Additional context

No response
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
cfd5dc9 
also improving informOnCondition
@shawkins shawkins mentioned this issue Apr 21, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
7450c48 
also improving informOnCondition
@shawkins
Copy link
Contributor Author

I think this only started to be an issue after supporting batching #3587 - before once a list was obtained it was set on the store as a single replace operation.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 21, 2022
@shawkins
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
e49929a 
also improving informOnCondition
@manusa manusa added this to the 6.0.0 milestone Apr 26, 2022
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Apr 28, 2022
@shawkins @manusa
fix fabric8io#4081 fabric8io#4082: correcting/removing versionable
0f3c8f8 
also improving informOnCondition
manusa pushed a commit that referenced this issue Apr 28, 2022
@shawkins @manusa
fix #4081 #4082: correcting/removing versionable
03ec3b1 
also improving informOnCondition
@manusa manusa mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
2 participants
@manusa @shawkins