Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional patch methods #4142

Closed
shawkins opened this issue May 12, 2022 · 1 comment · Fixed by #4143
Closed

Additional patch methods #4142

shawkins opened this issue May 12, 2022 · 1 comment · Fixed by #4143
Assignees
@shawkins
Milestone
6.0.0

Comments

@shawkins
Copy link
Contributor

patch() and patch(context) should be added.

Also for consistency patch(item) should be deprecated. And the javadocs should be updated that it does not reference the current item as the base.
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 12, 2022
@shawkins
fix fabric8io#4142: additional patch methods
1658ea9 
also correcting the javadocs wrt the patch base item.

removing logic that infers from the passed in item as the context will
already have the necessary information
@shawkins shawkins mentioned this issue May 12, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 13, 2022
@shawkins
fix fabric8io#4142: additional patch methods
73a164a 
also correcting the javadocs wrt the patch base item.

removing logic that infers from the passed in item as the context will
already have the necessary information
@manusa manusa added this to the 6.0.0 milestone May 17, 2022
@manusa
Copy link
Member

manusa commented May 17, 2022

Relates to #4137

manusa pushed a commit that referenced this issue May 17, 2022
@shawkins @manusa
fix #4142: additional patch methods
5133ad8 
also correcting the javadocs wrt the patch base item.

removing logic that infers from the passed in item as the context will
already have the necessary information
@shawkins shawkins mentioned this issue Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawkins shawkins

Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

fix #4142: additional patch methods shawkins/kubernetes-client
2 participants
@manusa @shawkins