Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Change JettyHttpClient#sendAsync method to not read full response in memory #4201

Closed
manusa opened this issue Jun 10, 2022 · 1 comment · Fixed by #4430
Closed

[refactor] Change JettyHttpClient#sendAsync method to not read full response in memory #4201

manusa opened this issue Jun 10, 2022 · 1 comment · Fixed by #4430
Assignees
@manusa
Milestone
6.3.0

Comments

@manusa
Copy link
Member

manusa commented Jun 10, 2022 •
edited
Loading

Is your enhancement related to a problem? Please describe

Currently, the JettyHttpClient#sendAsync method reads the response completely in-memory before completing the future, even for streaming return types (Readable or InputStream).

Describe the solution you'd like

Provide alternative response listener implementation for InputStream and Readable so that the future is complete as soon as the response is received and we pipe the packets as an InputStream.

Describe alternatives you've considered

No response

Additional context

No response
@manusa manusa self-assigned this Jun 10, 2022
@manusa manusa added this to the 6.x milestone Jun 10, 2022
@manusa manusa mentioned this issue Jun 10, 2022
Merged
11 tasks
@shawkins
Copy link
Contributor

ExecWatchInputStream can be adapted for use with http logic as well.

@shawkins shawkins modified the milestones: 6.x, 6.1.0 Jul 6, 2022
@shawkins shawkins mentioned this issue Aug 1, 2022
Merged
11 tasks
@manusa manusa modified the milestones: 6.1.0, 6.2.0 Aug 31, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 19, 2022
@shawkins
fix fabric8io#4201: generalizing sendAsync support
23ad882
@shawkins shawkins mentioned this issue Sep 19, 2022
Merged
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Sep 30, 2022
@shawkins
fix fabric8io#4201: generalizing sendAsync support
ed64589
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 5, 2022
@shawkins
fix fabric8io#4201: ensuring okhttp is tolerant to multiple consume c…
8633662 
…alls

also converting jetty to fully non-blocking

and adapting the body delivery for jdk for use with sendAsync logic - we
need the AsyncBody to be available immediately
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 5, 2022
@shawkins
fix fabric8io#4201: ensuring okhttp is tolerant to multiple consume c…
acbc310 
…alls

also converting jetty to fully non-blocking

and adapting the body delivery for jdk for use with sendAsync logic - we
need the AsyncBody to be available immediately
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 6, 2022
@shawkins
fix fabric8io#4201: ensuring okhttp is tolerant to multiple consume c…
32dd003 
…alls

also converting jetty to fully non-blocking

and adapting the body delivery for jdk for use with sendAsync logic - we
need the AsyncBody to be available immediately
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 6, 2022
@shawkins
fix fabric8io#4201: ensuring okhttp is tolerant to multiple consume c…
130d42a 
…alls

also converting jetty to fully non-blocking

and adapting the body delivery for jdk for use with sendAsync logic - we
need the AsyncBody to be available immediately
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 18, 2022
@shawkins
fix fabric8io#4201: jetty's bytebuffers may be immediately re-used
7c18d9f
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Oct 18, 2022
@shawkins
fix fabric8io#4201: jetty's bytebuffers may be immediately re-used
9156cde
@manusa manusa modified the milestones: 6.2.0, 6.x, 6.3.0 Oct 18, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 22, 2022
@shawkins
fix fabric8io#4201: adding missing test timeouts
e3db5f4
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 22, 2022
@shawkins
fix fabric8io#4201: changing how the jetty session is set and adding …
e832d26 
…missing test

timeouts
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 22, 2022
@shawkins
fix fabric8io#4201: changing how the jetty session is set
45d605b 
adding missing test timeouts
correcting the wait in HttpClientReadableByteChannel
manusa added a commit that referenced this issue Nov 29, 2022
@manusa
Merge pull request #4430 from shawkins/4201
432c48a 
fix #4201: generalizing sendAsync support
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 29, 2022
@shawkins
fix fabric8io#4201: moving consumeLines out of the clients
6f31d2a
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 29, 2022
@shawkins
fix fabric8io#4201: moving consumeLines out of the clients
b2456ca
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 29, 2022
@shawkins
fix fabric8io#4201: moving consumeLines out of the clients
57b905d
manusa added a commit that referenced this issue Nov 30, 2022
@manusa
Merge pull request #4619 from shawkins/consumeLines
b743b2f 
fix #4201: moving consumeLines out of the clients
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging a pull request may close this issue.

fix #4201: generalizing sendAsync support shawkins/kubernetes-client
2 participants
@manusa @shawkins