Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserializing Kube and custom resources from the same template #4590

Closed
paulcb1 opened this issue Nov 18, 2022 · 1 comment · Fixed by #4593
Closed

Deserializing Kube and custom resources from the same template #4590

paulcb1 opened this issue Nov 18, 2022 · 1 comment · Fixed by #4593
Assignees
Milestone

Comments

@paulcb1
Copy link

paulcb1 commented Nov 18, 2022

Is your enhancement related to a problem? Please describe

View initial discussion

Deserializing a template containing both Kube objects and custom resources fails with:
io.fabric8.kubernetes.client.KubernetesClientException: Cannot edit with visitors, no builder was found at io.fabric8.kubernetes.client.ResourceHandlerImpl.edit(ResourceHandlerImpl.java:59) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.acceptVisitors(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:292) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.lambda$getItems$1(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:112) at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.getItems(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:114) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.resources(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:119) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.getResources(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:124) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.performOperation(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:327) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.get(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:224) at io.fabric8.kubernetes.client.dsl.internal.NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.get(NamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl.java:62)

Describe the solution you'd like

Comment from @shawkins in original discussion:

Ok yes that exception is currently expected when resource does not have a builder, but it actually wouldn't take much to make this go away - a builder isn't really required to just change the namespace which is what it's trying to do here. Feel free to open an issue for this.

Describe alternatives you've considered

No response

Additional context

Version 6.1.1

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 18, 2022
@shawkins shawkins self-assigned this Nov 18, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 19, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 19, 2022
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Nov 20, 2022
@Abdullahqasim75
Copy link

Hi i am new to open source i know the java could anyone help me to find some good first issues to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants