OpenShift s2i binary builds seem broken in 6.3

[manusa]

Describe the bug

While upgrading Eclipse JKube to use Kubernetes Client 6.3.1 eclipse-jkube/jkube#1988, we've detected that binary builds are not completed.

It seems that the binary upload is not working as expected and the HTTP request never completes.

The call:

client.buildConfigs()
  .inNamespace(namespace)
  .withName(buildName)
  .instantiateBinary()
  .fromFile(binaryTarFile);

will hang forever.

There's a very simple unit test to verify this logic:

kubernetes-client/kubernetes-tests/src/test/java/io/fabric8/openshift/client/server/mock/BuildConfigTest.java

Line 208 in 1e944fc

void testBinaryBuildFromFileWithDefaults() throws IOException {

But there's no real e2e test verifying this scenario.

Fabric8 Kubernetes Client version

6.3.1

Steps to reproduce

Create an OpenShift binary build:

client.buildConfigs()
  .inNamespace(namespace)
  .withName(buildName)
  .instantiateBinary()
  .fromFile(binaryTarFile);

Expected behavior

The binary build should complete successfully

Runtime

OpenShift

Kubernetes API Server version

other (please specify in additional context)

Environment

Linux

Fabric8 Kubernetes Client Logs

No response

Additional context

Point of failure:

kubernetes-client/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildConfigOperationsImpl.java

Lines 267 to 271 in 1d3e263

	return waitForResult(handleResponse(newClient, requestBuilder, new TypeReference<Build>() {
	@Override
	public Type getType() {
	return Build.class;
	}

kubernetes-client/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/OperationSupport.java

Line 515 in 1d3e263

protected <T> T waitForResult(CompletableFuture<T> future) throws IOException {

[shawkins]

Ignore my previous comment. This is the place in the code that uses expectContinue - which is broken against things like the mock server depending upon which client is be used. What client is being used in this scenario?

[manusa]

What client is being used in this scenario?

OkHttp / OpenShiftClient

https://github.com/eclipse/jkube/blob/d7b92219c2fe94d68831e9016b943d851a0040e0/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildService.java#L443

When upgrading JKube to 6.3.1 (eclipse-jkube/jkube#1988) the oc:build goal which performs an S2i binary build will freeze in the step in which the binary is uploaded to the server. Cancelling the local operation after a while will unlock the server process so the cluster will continue with the build. It's my understanding that the binary is uploaded, but the client doesn't get notified of the request completion (but need to investigate more though)

[manusa]

It seems that the Expect header is using a wrong value:

kubernetes-client/kubernetes-client-api/src/main/java/io/fabric8/kubernetes/client/http/StandardHttpHeaders.java

Line 28 in 73572bb

public static final String EXPECT_CONTINUE = "100-Continue";

This value is case-sensitive and should be 100-continue instead.

Since expectContinue is used here:

kubernetes-client/openshift-client/src/main/java/io/fabric8/openshift/client/dsl/internal/build/BuildConfigOperationsImpl.java

Line 265 in 73572bb

.expectContinue()

and this is the switch to the constant is the most notable change between 6.1 and 6.3, it's very likely that the problem is related to it.

An easy way to check this is by using the JDK client instead, since it's not relying on the constant.

[manusa]

Should be fixed by #4766