deps: bump kubernetes-client to 6.4.0 #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1988 (2023-01-24T06:38:31Z) ⚙️ JKube E2E Tests (3993480349)
|
manusa
force-pushed
the
deps/kubernetes-client
branch
4 times, most recently
from
74c61cd to
867269e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1988 +/- ##
=========================================
Coverage 54.11% 54.11%
+ Complexity 4050 4048 -2
=========================================
Files 480 480
Lines 21061 21061
Branches 2812 2812
=========================================
Hits 11397 11397
+ Misses 8499 8496 -3
- Partials 1165 1168 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
manusa
force-pushed
the
deps/kubernetes-client
branch
from
867269e to
85cf411
Compare
manusa
force-pushed
the
deps/kubernetes-client
branch
from
85cf411 to
4ee1006
Compare
manusa
changed the title
manusa
force-pushed
the
deps/kubernetes-client
branch
from
4ee1006 to
e38da84
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
deps/kubernetes-client
branch
from
e38da84 to
7d0aafd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
...ava/org/eclipse/jkube/kit/config/service/openshift/OpenshiftBuildServiceIntegrationTest.java
Show resolved
Hide resolved
sunix
reviewed
Jan 25, 2023
| @AfterEach | ||
| void tearDown() { | ||
| kubernetesClientMockedConstruction.close(); | ||
| clusterConfiguration = ClusterConfiguration.builder() |
There was a problem hiding this comment.
it may be good to explain in the PR description why these changes were made and any reference to a kubernetes-client PR/issue
There was a problem hiding this comment.
These changes are just to improve the test and make use of the Kubernetes Mock Server provided by the client instead of relying on complex Mocks.
Why now? The Kubernetes Mock server as become more stable and performant over the last couple of years. Being able to test ClusterAccess against a semi-real cluster is easier to maintain than relying on Mocks that need extra-maintenance. In this case, the Client is slowly moving to abstract away explicit KubernetesClient implementations and moving on to SPI provided and more generic ones instead.
There was a problem hiding this comment.
this is good for me, ideally in the description or in another PR
rohanKanojia
approved these changes
Jan 25, 2023
sunix
approved these changes
Jan 25, 2023
|
This should also fix #1540 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deps: bump kubernetes-client to 6.4.0
This PR includes changes to the
ClusterAccessTest. The Kubernetes Mock server as become more stable and performant over the last couple of years. Being able to testClusterAccessagainst a semi-real cluster is easier to maintain than relying on Mocks that need extra-maintenance. In this case, the Client is slowly moving to abstract away explicit KubernetesClient implementations and moving on to SPI provided and more generic ones instead.Type of change
test, version modification, documentation, etc.)
Checklist