Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout consolidation #4911

Closed
shawkins opened this issue Feb 23, 2023 · 0 comments · Fixed by #4949
Closed

Timeout consolidation #4911

shawkins opened this issue Feb 23, 2023 · 0 comments · Fixed by #4949
Assignees
Milestone

Comments

@shawkins
Copy link
Contributor

shawkins commented Feb 23, 2023

There's a recognition on several issues that there are too many timeouts that are not all well defined.

On eclipse-jkube/jkube#2024 it was agreed that writeTimeout should be removed as primary concern.

The other timeouts:

  1. Config/RequestConfig requestTimeout - applied as the HttpClient readTimeout and enforced at OperationSupport.waitForResult
  2. Config/RequestConfig scaleTimeout - used for scale operations when the wait boolean is specified. Wth the rolling logic deprecated Config / RequestConfig rollingTimeout is unused #4826 the internal call to scaling will be removed, so the only place will be from the user scale call.
  3. Config/RequestConfig websocketTimeout - the readTimeout specifically for websocket requests - used two different ways. Watches set it as the readTimeout on the client, while exec waits on the initial future for that amount of time.
  4. readyWaitTimeout / logWaitTimeout - many pod operations check if the pod is in a good state prior to performing the operation
  5. delete timeout - uses a common context timeout value, turns the delete into a blocking operation - applied for each delete when operating over a collection
  6. openshift buildconfig timeout - also uses the common context timeout value - applies to how long it takes to upload the build and get the response back
  7. Config/RequestConfig connectionTimeout - applied as the connection timeout

Let's discuss how to collapse / combine these.

shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 3, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 3, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 3, 2023
@shawkins shawkins mentioned this issue Mar 3, 2023
11 tasks
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 3, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Mar 30, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Apr 19, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 12, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 12, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 12, 2023
@manusa manusa added this to the 6.7.0 milestone May 16, 2023
manusa pushed a commit to shawkins/kubernetes-client that referenced this issue May 16, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 16, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 16, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 16, 2023
shawkins added a commit to shawkins/kubernetes-client that referenced this issue May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants