Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load request config when intercepting request #1037

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Load request config when intercepting request #1037

merged 1 commit into from
Mar 20, 2018

Conversation

lulf
Copy link
Contributor

@lulf lulf commented Mar 20, 2018

This fixes an issue where the request config given in withRequestConfig is not applied.

@piyush-garg
Copy link
Contributor

Hey @lulf

Thanks for the PR. Can you please add this to CHANGELOG.md and also can you please refer to the issue which gets resolved by this. Thanks

@oscerd
Copy link
Member

oscerd commented Mar 20, 2018

ok to test

@oscerd
Copy link
Member

oscerd commented Mar 20, 2018

[merge]

1 similar comment
@oscerd
Copy link
Member

oscerd commented Mar 20, 2018

[merge]

@fusesource-ci fusesource-ci merged commit 5651787 into fabric8io:master Mar 20, 2018
@lulf
Copy link
Contributor Author

lulf commented Mar 20, 2018

@piyush1594 See #1038

@lulf lulf deleted the impersonation-request-load branch March 20, 2018 11:00
@piyush-garg
Copy link
Contributor

Thanks @lulf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lulf @piyush-garg @oscerd @fusesource-ci