Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support client.authentication.k8s.io/v1beta1 #1348

Merged

Conversation

jglick
Copy link
Contributor

@jglick jglick commented Feb 6, 2019

Amends #1224 to support the current apiVersion documented here. With #1347 worked around, this has been successfully tested on a GKE cluster using

users:
- name: gcp
  user:
    exec:
      apiVersion: "client.authentication.k8s.io/v1beta1"
      command: "sh"
      args:
        - "-c"
        - |
            gcloud config config-helper --format=json | jq '{"apiVersion": "client.authentication.k8s.io/v1beta1", "kind": "ExecCredential", "status": {"token": .credential.access_token, "expirationTimestamp": .credential.token_expiry}}'

(The gcloud container clusters get-credentials command recommended by Google rewrites your ~/.kube/config to use

users:
- name: 
  user:
   auth-provider:
     name: gcp
     config:
       access-token: 
       cmd-args: config config-helper --format=json
       cmd-path: gcloud
       expiry: 
       expiry-key: '{.credential.token_expiry}'
       token-key: '{.credential.access_token}'

which Config does not support, and which I think is semi-deprecated.)

@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia
Copy link
Member

ok to test

Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Feb 6, 2019
@rohanKanojia rohanKanojia removed the changelog missing A line to changelog.md regarding the change is not added label Feb 7, 2019
@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit bdf41c3 into fabric8io:master Feb 7, 2019
@jglick jglick deleted the client.authentication.k8s.io/v1beta1 branch February 7, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants