Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several informer related changes #3981

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Several informer related changes #3981

merged 2 commits into from
Mar 25, 2022

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Mar 18, 2022

Description

This addresses a host of informer related requests:

Fix #3969 - stop emitting sync events on relist - it was simplest to make this change to support #3968
Fix #3968 - added SharedInformer.initialState to set

Also took the parts of #3943 that were most general purpose, such as being able to add/remove indexers at any time, along with deprecating Informable.withIndexers

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

also allowing for indexers to be added/removed at runtime, and exposing
Store.getKey
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@shawkins shawkins added this to the 6.0.0 milestone Mar 24, 2022
@manusa manusa merged commit 2f65ca6 into fabric8io:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onUpdate is called on re-list even if resourceVersion is unchaged The Store API is not writable
3 participants