Delete issues

[shawkins]

Description

Addressing various delete issues from #3982

• adding deleteList methods that provide more information about exactly what has been deleted
• clarified the javadocs of existing delete methods
• have delete() of a list return false when an item can't be deleted
• added these changes to the resourceList interfaces - it was easiest to remove what had already been deprecated

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[XComp]

Thanks for addressing my comments, @shawkins . I only looked at the list deletion code I described in #3982 . It fixes the overall issue. I have a few comments, though. Please have a look below.

[shawkins]

@XComp this pr will change based upon the comments #3982

[shawkins]

@manusa here's what this looks like with keeping the boolean return.

[shawkins]

After chatting with @manusa we'll update to returning void for now, and capture a new issue for implementing collection delete against the api server (should be a small change) with the eventual goal of processing the return from single item and collection delete to return a list of objects or ids.

[shawkins]

The big issue with changing to void rather than boolean is fixing up all of the tests - there are a couple hundred places where we are checking for that response. I'll separate that off as a different issue.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

37.5% Coverage
0.0% Duplication