Consistent/expanded usage of the resource term #3994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawkins
force-pushed
the
resource
branch
3 times, most recently
from
f25b2f1
to
70d2923
Compare
|
Marking as ready for review now that the non-static changes are in. |
manusa
reviewed
Mar 25, 2022
| @@ -1011,4 +1012,9 @@ public static URL appendListOptionParams(URL base, ListOptions listOptions) { | |||
| return urlBuilder.build(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Stream<R> resources() { | |||
| return list().getItems().stream().map(this::resource); | |||
There was a problem hiding this comment.
What's the purpose of the map/peek? It will set the last listed item as the current item.
There was a problem hiding this comment.
map does not perform a peek, it will convert from a stream of HasMetadata to a stream of Resources
There was a problem hiding this comment.
OK, GH interface is playing dirty again.
manusa
reviewed
Mar 25, 2022
| @@ -0,0 +1,15 @@ | |||
| # | |||
There was a problem hiding this comment.
That looks unintentional. I'll back that out as this file is going away in the other pr.
also making PodResource non-generic
resource # Conflicts: # kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/ResourceTest.java
|
SonarCloud Quality Gate failed. |
manusa
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements #3973, it is layered on top of the changes for #3875 to minimize conflicts - so only the last commit is of interest and this will get rebased prior to inclusion.
The change here is instead of withItem, we'll use resource, then instead getResources off of a resourceList, we'll use resources, and finally there's the addition of a convenience method resources, which serves the same purpose as the resourceList method.
This requires making watchlistdeletable more generic as we need the resource type. It also makes podresource non-generic as that is not needed.
Type of change
test, version modification, documentation, etc.)
Checklist