fix: IntOrString supports null values

[manusa]

Description

fix: IntOrString supports null values

• For backwards compatibility, IntOrString should still support
  null values.

Relates to:

• refactor (kubernetes-model-core) : Refactor IntOrString class to avoid invalid field combinations #3806

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Checklist

• Code contributed by me aligns with current project license: Apache 2.0
• I Added CHANGELOG entry regarding this change
• I have implemented unit tests to cover my changes
• I have added/updated the javadocs and other documentation accordingly
• No new bugs, code smells, etc. in SonarCloud report
• I tested my code in Kubernetes
• I tested my code in OpenShift

[rohanKanojia]

Why are we doing this? Did someone reported this issue? Was it breaking some deserialization ?

[manusa]

Why are we doing this? Did someone reported this issue? Was it breaking some deserialization ?

It breaks lots of stuff in JKube. In addition, it also makes sense that if you have a public empty constructor which leaves the value as null, that you can actually pass a null argument to the other constructor too.

So considering that this is harmless, the resulting object instance can also be achieved via the other constructor, and that it makes the changes backwards-compatible, IMHO we should keep it this way.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication