Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated [client.secrets] createOrReplace #4582

Merged
merged 2 commits into from
Nov 17, 2022
Merged

updated [client.secrets] createOrReplace #4582

merged 2 commits into from
Nov 17, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Nov 17, 2022 •
edited by manusa
Loading

Description

Fixes #4580

The method createOrReplace(Secret) from the type ItemWritableOperation is deprecated but this is in the doku

Secret createdSecret = client.secrets().inNamespace("default").createOrReplace(secret1);

changed to

Secret createdSecret = client.secrets().inNamespace("default").resource(secret1).createOrReplace();

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

#4580

@SaumyaBhushan
Copy link
Contributor Author

@rohanKanojia @manusa Please review it .

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manusa manusa added this to the 6.3.0 milestone Nov 17, 2022
@manusa manusa merged commit f58b1dd into fabric8io:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@manusa manusa manusa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.3.0
Development

Successfully merging this pull request may close these issues.

[client.secrets] createOrReplace is deprecated but its in the doku
3 participants
@SaumyaBhushan @manusa @oscerd