Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4670: using a 0 resourceVersion for the initial informer listing #4676

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix #4670: using a 0 resourceVersion for the initial informer listing #4676

merged 2 commits into from
Dec 20, 2022

Conversation

shawkins
Copy link
Contributor

Description

Addresses #4670 by setting an initial list resourceVersion of 0, which matches the behavior of the go client.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

oscerd
oscerd approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@oscerd oscerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

62.5% 62.5% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.4.0 milestone Dec 20, 2022
@manusa manusa merged commit 1e42516 into fabric8io:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shawkins @manusa @oscerd