Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fix occasional CRD generation issues with subresources #4699

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Attempt to fix occasional CRD generation issues with subresources #4699

merged 2 commits into from
Jan 3, 2023

Conversation

andreaTP
Copy link
Member

Description

This is an attempt to fix #4680

I think that the Decorator I'm touching might be the root cause of the issue (directly or inderectly related).
Overall, this implementation should be more solid than before.
Let see how it goes 🤞

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@andreaTP andreaTP requested a review from metacosm December 19, 2022 17:51
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.0% 19.0% Coverage
0.0% 0.0% Duplication

@andreaTP
Copy link
Member Author

andreaTP commented Jan 3, 2023

can I ask for another review @manusa maybe?

@manusa manusa added this to the 6.4.0 milestone Jan 3, 2023
@manusa
Copy link
Member

manusa commented Jan 3, 2023

was just reaching this one 😅

@manusa manusa merged commit 0bce8c4 into fabric8io:master Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd

@shawkins shawkins Awaiting requested review from shawkins

@sunix sunix Awaiting requested review from sunix

@metacosm metacosm Awaiting requested review from metacosm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

Occasional CRD generation test error
3 participants
@andreaTP @manusa @rohanKanojia