Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #4249 #4726: toning down logging of errors #4730

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix #4249 #4726: toning down logging of errors #4730

merged 1 commit into from
Jan 11, 2023

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Jan 4, 2023 •
edited by manusa
Loading

Description

Fix #4249
Fix #4726

There are a lot of unnecessary error logging in the portforwarding logic - in general we should not log something at an error level that is provided to the user. In this case there are both client and server throwables returned. A small change was to also map protocol errors to server exceptions so that they would be available as well.

For the exec logic there's no need to log or provide the exception to the listener if we're already finished.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

64.3% 64.3% Coverage
0.0% 0.0% Duplication

@manusa manusa added this to the 6.4.0 milestone Jan 11, 2023
@manusa manusa merged commit 73572bb into fabric8io:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@sunix sunix sunix approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd Awaiting requested review from oscerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
4 participants
@shawkins @manusa @sunix @rohanKanojia