feat: add factory methods to help with SSA #6013
Conversation
metacosm
requested review from
oscerd,
rohanKanojia,
shawkins and
sunix
as code owners
...nerator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/HasMetadata.java
Outdated
Show resolved
Hide resolved
...nerator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/HasMetadata.java
Outdated
Show resolved
Hide resolved
metacosm
force-pushed
the
new-instance
branch
3 times, most recently
from
02f3589 to
47a508b
Compare
| * @return a new ObjectMetaBuilder instance initialized with the name and namespace (if the resource it is called on is a | ||
| * namespaced one) of the specified ObjectMeta | ||
| */ | ||
| default ObjectMetaBuilder initMetadataBuilderNameAndNamespaceFrom(ObjectMeta original) { |
There was a problem hiding this comment.
Let's make this one static - it does not need access to the current instance.
There was a problem hiding this comment.
Makes sense. I originally hoped that I could set the metadata on the current instance as well.
There was a problem hiding this comment.
static ObjectMetaBuilder initMetadataBuilderNameAndNamespaceFrom(ObjectMeta original)
gives you the usage:
new SomethingBuilder().withMetadata(HasMetadata.initMetadataBuilderNameAndNamespaceFrom(original)....build())...
An alternative which doesn't quite set the metadata, but allows you to do so more fluently:
static <A extends ObjectMetaFluent<A>> A withNameAndNamespace(A value, HasMetadata original) {
gives you the usage:
HasMetadata.withNameAndNamespace(new SomethingBuilder().withNewMetadata(), original)...endMetadata()...
There was a problem hiding this comment.
Actually, it does access the current instance to check if it is Namespaced or not to decide whether to use and set the namespace…
There was a problem hiding this comment.
@metacosm I think I was assuming based upon your other comment though it could instead be:
static ObjectMetaBuilder initMetadataBuilderNameAndNamespaceFrom(HasMetadata original)
But didn't make that change in the signature shown above.
There was a problem hiding this comment.
Gotcha. Sorry for being slow, it's been a long day. 😓
...nerator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/HasMetadata.java
Show resolved
Hide resolved
metacosm
force-pushed
the
new-instance
branch
3 times, most recently
from
c4607e7 to
baac39f
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
|
Description
Fixes #6012
Type of change
test, version modification, documentation, etc.)
Checklist