Remove project from task extension

[Sineaggi]

In order to support Gradle's configuration cache, having the Project object in extensions/tasks is not allowed https://docs.gradle.org/current/userguide/configuration_cache.html#config_cache:requirements:disallowed_types. We can avoid that by injecting the ProjectLayout object directly which is legal.

There are a number of types that task instances must not reference from their fields.
These types fall into some categories as follows:

• Live JVM state types
• Gradle model types
• Dependency management types

In all cases the reason these types are disallowed is that their state cannot easily be stored or recreated by the configuration cache.

Specifically

Gradle model types (e.g. Gradle, Settings, Project, SourceSet, Configuration etc…​) are usually used to carry some task input that should be explicitly and precisely declared instead.

[andreaTP]

I don't know much about Gradle plugins, but looks good to me.

cc. @manusa

[rohanKanojia]

@Sineaggi : Could you please fix style errors with mvn spotless:apply?

[rohanKanojia]

@Sineaggi : Do you know if this configuration cache requirement was added since Gradle 8.x ?

[Sineaggi]

@Sineaggi : Do you know if this configuration cache requirement was added since Gradle 8.x ?

I think since a minor version of Gradle 6.x, not sure which exactly. This does not prevent the plugin from running on Gradle 8.x, but it does break projects that attempt to enable configuration cache.

[Sineaggi]

Without these changes, we get the following error

2 problems were found storing the configuration cache.
- Task `:app:crd2java` of type `io.fabric8.java.generator.gradle.plugin.task.JavaGeneratorCrd2JavaTask`: cannot deserialize object of type 'org.gradle.api.Project' as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.7/userguide/configuration_cache.html#config_cache:requirements:disallowed_types
- Task `:app:crd2java` of type `io.fabric8.java.generator.gradle.plugin.task.JavaGeneratorCrd2JavaTask`: cannot serialize object of type 'org.gradle.api.internal.project.DefaultProject', a subtype of 'org.gradle.api.Project', as these are not supported with the configuration cache.
  See https://docs.gradle.org/8.7/userguide/configuration_cache.html#config_cache:requirements:disallowed_types

No errors with this change.

[Sineaggi]

Normally I'd be able to create a test (via GradleRunner) that starts up Gradle with the plugin, but I wasn't having much luck getting that to work from maven.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
60.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Sineaggi]

Good to merge?

[manusa]

Good to merge?

Yes it is.

However, I'd like to check a few things locally. I'll probably merge on Friday.

Sorry for the delay.

[manusa]

LGTM, thx!