Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods from KubernetesClientException class #6629 #6633

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

asharan2buff
Copy link
Contributor

@asharan2buff asharan2buff commented Nov 20, 2024

Remove deprecated constructors and methods and ran the tests to ensure nothing is failing

Description

Fixes #6629

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…8io#6629

Remove deprecated constructors and methods and ran the tests to ensure nothing is failing
this(message, t, -1, null,
RequestMetadata.builder().group(group).version(version).plural(resourcePlural).namespace(namespace).build());
}
// Removed deprecated constructors and methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this comment. This should be part of your commit message instead.

}
return launderThrowable(sb.toString(), cause);
}
// Removed deprecated constructors and methods
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this comment.

@manusa manusa added this to the 7.0.0 milestone Nov 20, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 5343445 into fabric8io:main Nov 20, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods from KubernetesClientException class
3 participants