-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text): styles #9081
fix(text): styles #9081
Conversation
…c.js into patch-text-styles
commit b78dda2 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 12:58:28 2023 +0900 Update Text.ts commit 7119251 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 12:53:55 2023 +0900 Update Text.ts commit 5b904af Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 12:46:28 2023 +0900 FINALLY OMG commit 2cc92a5 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 12:24:31 2023 +0900 strict commit ac081d1 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 12:06:40 2023 +0900 go commit 652a345 Merge: 0ba2c8d e0034f5 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 09:10:36 2023 +0900 Merge branch 'fix-9010' of https://github.com/fabricjs/fabric.js into fix-9010 commit 0ba2c8d Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 09:10:10 2023 +0900 f******9 commit e0034f5 Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Sun Jul 9 00:07:11 2023 +0000 update CHANGELOG.md commit 4c3f9f2 Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 08:55:10 2023 +0900 bullshit commit f2ccf8a Author: ShaMan123 <shacharnen@gmail.com> Date: Sun Jul 9 07:32:39 2023 +0900 fix but not fix fix Revert "fix" This reverts commit 656e25f. Update text.js
Update TextSVGExportMixin.ts
912bde4
to
a87c8d3
Compare
@ShaMan123 you are welcome to fix the bug, but not accepting those kind of refactors right now. |
The mess is unbearable |
Let's keep the conversation to the PR, since the related issue doesn't really say much else apart showing to video to be interpreted. |
The bug is to do with bad design |
text is amess @asturur |
Why is this bad design?Styles depend on layout (with no good reason) instead of depending on char offset from start. Styles should not depend on layout. |
You know is bad design also because i told you the story of Itext, it was a demo and so textbox was pushed in by some contributor that needed wrappingtext, all was made with no planning. Fixing countless of style bug between 1.5 and 2.0 was a nightmare for me too. We know text is a mess, repeating it won't make reafactor being accepted in this moment nor make the release happen faster. I drew a line for no more refactors untill a stable release and docs. This will need to wait for the next breaking release, meanwhile we can try to fix the bug with the ugly code or we can keep the bug a bit longer since is here since 3.x |
You are right |
Yeah but if you give me reproduction steps i can try. |
Start the vanilla app |
Motivation
closes #9028
Description
Extracts style logic to a manager
Styles has been refactored into an array mirroring the chars to make our lives easier.
In addition I have exposed a method
getDiffFromInputEvent
to make our lives easier.I have left the interface untouched so not to break, though I think we should remove all that bad interface.
Changes
Gist
TODO:
In Action