Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CollectionBuilder constructor using an AttributesBundle #1081

Merged
merged 5 commits into from
May 17, 2024

Conversation

edgarfgp
Copy link
Member

@edgarfgp edgarfgp commented May 13, 2024

Currently in Fabulous you can't pass a WidgetBuilder as part of the CollectionBuilder constructor using AttributesBundle.

Before

Screenshot 2024-05-13 at 21 23 58

After

Screenshot 2024-05-13 at 22 10 57

This PR changes the CollectionBuilder definition to use AttributesBundle.

@edgarfgp edgarfgp marked this pull request as ready for review May 13, 2024 21:12
Copy link
Member

@TimLariviere TimLariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition, This would be useful for more advanced scenario when dealing with CollectionBuilder. I made some comments.
Mainly watch out for the difference between Scalar and AttributeBundle.

src/Fabulous/Builders.fs Outdated Show resolved Hide resolved
src/Fabulous/Builders.fs Outdated Show resolved Hide resolved
edgarfgp and others added 2 commits May 15, 2024 18:02
Co-authored-by: Timothé Larivière <timothe.lariviere@outlook.com>
Co-authored-by: Timothé Larivière <timothe.lariviere@outlook.com>
@edgarfgp edgarfgp changed the title Replace StackList<ScalarAttribute> with AttributesBundle Add new CollectionBuilder constructor using an AttributesBundle May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants