Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E_NOTICE when requesting invalid script #449

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fix E_NOTICE when requesting invalid script #449

merged 1 commit into from
Feb 23, 2022

Commits on Feb 23, 2022

  1. Fix E_NOTICE when requesting invalid script 

    It is possible to trigger an exception by requesting an invalid script path.

The following URL path leads to XSS on the exception page,
showing two nice popups:

  http://myapp/_ignition/scripts/--><svg onload=alert(1337)>

The exception is:

  ErrorException
  Undefined index: --><svg onload=alert(1337)>

  Illuminate\Foundation\Bootstrap\HandleExceptions::handleError
  vendor/facade/ignition/src/Http/Controllers/ScriptController.php:14

This happens with facade/ignition 1.18.0 (the last with laravel 6 support)
and should be fixed there.
The error probably also occurs in all later versions.
    @cweiske
    cweiske committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    71412f1 View commit details
    Browse the repository at this point in the history