Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show crosswalk marking icons in marking type dropdown #1259

Open
cbeddow opened this issue Dec 11, 2023 · 5 comments
Open

Show crosswalk marking icons in marking type dropdown #1259

cbeddow opened this issue Dec 11, 2023 · 5 comments
Labels
feature-new New feature or request

Comments

@cbeddow
Copy link
Contributor

cbeddow commented Dec 11, 2023

Description

image

In this dropdown when editing a crosswalk, it would be awesome to show some graphic of the crossing type, similar to below:

image

I can work on making an SVG for each type if it is potentially able to be displayed next to the text there.

This would not be reflected in the actual icon of the preset.

@cbeddow cbeddow added the feature-new New feature or request label Dec 11, 2023
@bhousel
Copy link
Contributor

bhousel commented Dec 11, 2023

Cool - this feature did get added to iD last year, so if people find it useful we could support it in Rapid too.
I think most of the types do have icons assigned.
see: ideditor/schema-builder#56

@mxxcon
Copy link

mxxcon commented Dec 20, 2023

Yes, very useful feature to have. No need to remember the given names to different markings, especially since those names are often different from the tag values and on less commonly used types. Just look for the matching icon and select it 😄
Please add it.👍
image

@bhousel
Copy link
Contributor

bhousel commented Dec 27, 2023

Working on this today - it would be nice to get this into a patch release this week!

The ones shipped with iD are not drawn in a way that we can use them on markers, so I'll probably just redraw them. The are all pretty simple shapes.

Screenshot 2023-12-27 at 1 01 23 PM

@bhousel
Copy link
Contributor

bhousel commented Dec 28, 2023

Getting closer! The shapes are still just a bit too dense to work at 15px map pin size.
I'll refine them a bit more.

Screenshot 2023-12-27 at 9 24 56 PM

bhousel added a commit to rapideditor/temaki that referenced this issue Dec 28, 2023
bhousel added a commit to rapideditor/temaki that referenced this issue Dec 28, 2023
@bhousel
Copy link
Contributor

bhousel commented Jan 3, 2024

I realized I forgot to followup on this - the new presets actually shipped in yesterday's patch release v2.2.2 🎉

I did a lot of work to make sure they look pretty good at both the 40px preset icon size and the 15px map pin size.
see: https://rapideditor.github.io/temaki/docs/#group=crossings

The hope is that users scrolling around the map should be able to tell which crossings are mapped with crossing:markings detail.

I'll leave this issue open for now, because I haven't yet updated the dropdown component to show inline icons yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-new New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants