Do not throw IOException for init(Context,ExternalSoMapping) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67032849 |
…k#135) Summary: This mimics the same behavior of `init(Context, boolean)` and lifts the requirement for Java consumers to catch an exception explicitely. See facebook/react-native-website#4397 Reviewed By: cipolleschi Differential Revision: D67032849
cortinico
force-pushed
the
export-D67032849
branch
from
5d82c8f to
4565891
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67032849 |
|
This pull request has been merged in 71837f3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This mimics the same behavior of
init(Context, boolean)and lifts the requirement forJava consumers to catch an exception explicitely.
See facebook/react-native-website#4397
Differential Revision: D67032849