Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Add support for error prone as native compiler option #1047

Closed
wants to merge 3 commits into from
Closed

Add support for error prone as native compiler option #1047

wants to merge 3 commits into from
+130 −17

Commits on Mar 8, 2017

  1. SmartDexingStep: Rewrite lambda as function

    @davido
    davido committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    6fe3462 View commit details
    Browse the repository at this point in the history

  2. Add support for error prone as native compiler option 

    Fixes facebook#994.

Summary:
http://errorprone.info is a static analysis tool for Java that catches
common programming mistakes at compile-time. With this change it can
be permanenty or instantly activated as default compiler.

The configuration option: java.error_prone_javac is considered to be
experimental and is not documented.

Test Plan:

1. Permanently activate error prone: add this line to .buckconfig:

   [java]
     error_prone_javac = true

2. Instantly activate error prone:

  $ buck build --config java.error_prone_javac=true <rule>

3. Activate error prone per rule base:

  java_library(
    name = 'foo',
    error_prone_javac = True,
    [...]
    @davido
    davido committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    2c455f4 View commit details
    Browse the repository at this point in the history

  3. Run error prone checks in Travis CI

    @davido
    davido committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    33ed2be View commit details
    Browse the repository at this point in the history